Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Team formatting #24

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Team formatting #24

wants to merge 6 commits into from

Conversation

anthonyj33
Copy link
Member

@anthonyj33 anthonyj33 commented Mar 8, 2023 •
edited
Loading

Add titles to each team member's card + some formatting changes

@render
Copy link

render bot commented Mar 8, 2023

Your Render PR Server URL is https://treasure-hacks-site-pr-24.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-cg44iq9mbg57fo5oaov0.

@Awesome-E
Copy link
Member

  1. Consider putting white-space: nowrap on the title (gray text) so that they don't wrap

image

  1. Title should not be smaller than the paragraph text

  2. An additional line with the name and title above the description means you can probably reduce line-height of the paragraph element.

  3. Comma can be especially awkward if job title goes to the second line.

@anthonyj33 anthonyj33 marked this pull request as ready for review March 12, 2023 19:29
@anthonyj33 anthonyj33 requested a review from Awesome-E March 12, 2023 19:29
Awesome-E
Awesome-E requested changes Mar 12, 2023
View reviewed changes
views/style.scss Outdated
Comment on lines 1613 to 1615
color: #ababab;
white-space: nowrap;
font-size: 1.3rem;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is causing a spacing issue

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Awesome-E check it out now. fixed :D

@anthonyj33 anthonyj33 requested a review from Awesome-E March 12, 2023 20:45
@Awesome-E
improve spacing
c10e69b
@Awesome-E
update layout change threshold
08da8d4
@Awesome-E
Anthony please learn SCSS and respect formatting
4a8f1ad 
- Reorganize excess SCSS on the bottom of the file so that it is within the right parent rule
- Re-add newline at end of file
Awesome-E
Awesome-E requested changes Mar 12, 2023
View reviewed changes
Copy link
Member

@Awesome-E Awesome-E left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Still too big for the smallest screen size we support, which I believe is 350px.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Awesome-E Awesome-E Awesome-E requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anthonyj33 @Awesome-E